Fix import of items when feed does not exist #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grotax
force-pushed
the
fix/import-items
branch
from
ba8bf3e
to
15cd049
Compare
Codecov Report
@@ Coverage Diff @@
## master #1742 +/- ##
=========================================
Coverage 91.86% 91.86%
Complexity 766 766
=========================================
Files 65 65
Lines 2692 2705 +13
=========================================
+ Hits 2473 2485 +12
- Misses 219 220 +1
Continue to review full report at Codecov.
|
SMillerDev
approved these changes
Apr 17, 2022
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax
force-pushed
the
fix/import-items
branch
from
15cd049
to
be97de5
Compare
|
Currently the webinteface won't directly load the imported feed, you get redirected to the imported feed via the typical url but the webinterface doesn't have the content. A refresh is required... Another bug of the broken webinterface |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1562
The issue with the old logic was that it would create a new feed for each item as the feedLink coming from the json would never exist in the array of feeds.
Because the feed would be added with this placeholder url.
I don't see a need not to use this placeholder url and also no reason to disable updates.
I tested this by adding a feed, exporting the opml and the items.